diff options
| author | tpart <tpart120@proton.me> | 2025-07-13 23:06:02 +0200 |
|---|---|---|
| committer | tpart <tpart120@proton.me> | 2025-07-13 23:06:06 +0200 |
| commit | 207acb492d898b86b7e72d30cd02c1cf43a37f49 (patch) | |
| tree | d131d306e864f8c247c7325222464b7e16f3bad4 | |
| parent | 6de7722fa71165c116ac6a2a7eb0151ba2bd0468 (diff) | |
| download | hurrycurry-207acb492d898b86b7e72d30cd02c1cf43a37f49.tar hurrycurry-207acb492d898b86b7e72d30cd02c1cf43a37f49.tar.bz2 hurrycurry-207acb492d898b86b7e72d30cd02c1cf43a37f49.tar.zst | |
Fix some warnings regarding variable shadowing
| -rw-r--r-- | client/menu/settings/number_setting.gd | 16 | ||||
| -rw-r--r-- | client/menu/settings/path_setting.gd | 8 |
2 files changed, 12 insertions, 12 deletions
diff --git a/client/menu/settings/number_setting.gd b/client/menu/settings/number_setting.gd index dd6fd150..5fa5a115 100644 --- a/client/menu/settings/number_setting.gd +++ b/client/menu/settings/number_setting.gd @@ -17,19 +17,19 @@ class_name NumberSetting extends GameSetting var placeholder: String -var min: int -var max: int +var min_value: int +var max_value: int -func _init(new_id: String, default: int, min: int, max: int): - super(new_id, default) - self.min = min - self.max = max +func _init(new_id: String, new_default: int, new_min_value: int, new_max_value: int): + super(new_id, new_default) + min_value = new_min_value + max_value = new_max_value func create_row(): var row = super() var input := SpinBox.new() - input.min_value = min - input.max_value = max + input.min_value = min_value + input.max_value = max_value input.value_changed.connect(func(value): Global.set_setting(key, value as int)) Settings.hook_changed_init(key, true, diff --git a/client/menu/settings/path_setting.gd b/client/menu/settings/path_setting.gd index c599ffad..b09ccccd 100644 --- a/client/menu/settings/path_setting.gd +++ b/client/menu/settings/path_setting.gd @@ -24,14 +24,14 @@ var file_mode: FileDialog.FileMode func _init(new_id: String, new_default: String, - file_mode: FileDialog.FileMode, + new_file_mode: FileDialog.FileMode, new_placeholder: String = "", - access: FileDialog.Access = FileDialog.Access.ACCESS_FILESYSTEM + new_access: FileDialog.Access = FileDialog.Access.ACCESS_FILESYSTEM ): super(new_id, new_default) placeholder = new_placeholder - self.access = access - self.file_mode = file_mode + access = new_access + file_mode = new_file_mode func create_row(): var row = super () |