From 981a4bfbafc4213f65457a58c75f8a3eaf24d534 Mon Sep 17 00:00:00 2001 From: tpart Date: Mon, 23 Dec 2024 19:42:42 +0100 Subject: Fix crash with empty username string in character menu (Fix #232) --- client/menu/character.gd | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/client/menu/character.gd b/client/menu/character.gd index dd3bc5cd..fb224dd7 100644 --- a/client/menu/character.gd +++ b/client/menu/character.gd @@ -60,7 +60,12 @@ func _input(_event): func _on_back_pressed(): if username_edit.text == "": - await submenu("res://menu/warning_popup.tscn", tr("c.error.username_empty")) + var popup_data := MenuPopup.Data.new() + popup_data.text = tr("c.error.empty_username") + var accept_button := Button.new() + accept_button.text = tr("c.menu.accept") + popup_data.buttons = [accept_button] + await submenu("res://menu/popup.tscn", popup_data) return Global.set_profile("username", username_edit.text) -- cgit v1.2.3-70-g09d2 From ef4c2adba0a49401ba56504d9bb4256959e204cf Mon Sep 17 00:00:00 2001 From: tpart Date: Mon, 23 Dec 2024 19:47:20 +0100 Subject: Set maximum length of username to 32 in client (Fix #231) --- client/menu/character.tscn | 2 +- client/menu/setup.tscn | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/menu/character.tscn b/client/menu/character.tscn index bc4e1663..673f4489 100644 --- a/client/menu/character.tscn +++ b/client/menu/character.tscn @@ -87,7 +87,7 @@ horizontal_alignment = 1 [node name="username" type="LineEdit" parent="VBoxContainer/top_panel/a"] layout_mode = 2 -max_length = 16 +max_length = 32 [node name="Spacer" type="MarginContainer" parent="VBoxContainer"] layout_mode = 2 diff --git a/client/menu/setup.tscn b/client/menu/setup.tscn index 0ad994a5..df9642ad 100644 --- a/client/menu/setup.tscn +++ b/client/menu/setup.tscn @@ -192,7 +192,7 @@ tooltip_text = "c.setup.name.desc" [node name="LineEdit" type="LineEdit" parent="ScrollContainer/Control/TextureRect/PaperMargin/Contents/NameEntry"] custom_minimum_size = Vector2(300, 30) layout_mode = 2 -max_length = 64 +max_length = 32 [node name="Control" type="Control" parent="ScrollContainer/Control/TextureRect/PaperMargin/Contents/NameEntry"] layout_mode = 2 -- cgit v1.2.3-70-g09d2