From 9c636b231b432976d9d7c3044f9e488f0f7cedf3 Mon Sep 17 00:00:00 2001 From: metamuffin Date: Thu, 18 Sep 2025 22:38:12 +0200 Subject: Fix bug showing lobby in game; Fix race condition/UB in scene transition --- client/gui/menus/transition/scene_transition.gd | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'client/gui/menus/transition') diff --git a/client/gui/menus/transition/scene_transition.gd b/client/gui/menus/transition/scene_transition.gd index 330d67d6..332647b5 100644 --- a/client/gui/menus/transition/scene_transition.gd +++ b/client/gui/menus/transition/scene_transition.gd @@ -24,6 +24,8 @@ var s_current = false var s_target = false var fading = false +signal animation_end + func _ready(): $black.visible = true text.visible = true @@ -34,7 +36,7 @@ func set_loading_text(s: String): text_anim.play("fade") func next(): - while fading: await black_anim.animation_finished + while fading: await animation_end if s_target == s_current: return fading = true if s_target: @@ -53,6 +55,7 @@ func next(): await get_tree().process_frame # animation finishes one frame early s_current = false fading = false + animation_end.emit() await next() func fade_in(): -- cgit v1.2.3-70-g09d2