aboutsummaryrefslogtreecommitdiff
path: root/client/map
diff options
context:
space:
mode:
authormetamuffin <metamuffin@disroot.org>2025-10-08 01:01:53 +0200
committermetamuffin <metamuffin@disroot.org>2025-10-08 01:01:53 +0200
commitfe711a11cfcfeca06c085a56f2e1d5f68a049337 (patch)
tree42d6bd6ef076b95ab86e64dda36552e45fd34a11 /client/map
parent4e655f4e648b64b6f416da7183a8d555745fa163 (diff)
downloadhurrycurry-fe711a11cfcfeca06c085a56f2e1d5f68a049337.tar
hurrycurry-fe711a11cfcfeca06c085a56f2e1d5f68a049337.tar.bz2
hurrycurry-fe711a11cfcfeca06c085a56f2e1d5f68a049337.tar.zst
Unhook setting callbacks when hooking node is freed
Diffstat (limited to 'client/map')
-rw-r--r--client/map/auto_setup/environment_setup.gd6
-rw-r--r--client/map/auto_setup/light_setup.gd2
-rw-r--r--client/map/map.gd2
3 files changed, 5 insertions, 5 deletions
diff --git a/client/map/auto_setup/environment_setup.gd b/client/map/auto_setup/environment_setup.gd
index 7b6c5c8a..2dc5ea36 100644
--- a/client/map/auto_setup/environment_setup.gd
+++ b/client/map/auto_setup/environment_setup.gd
@@ -22,9 +22,9 @@ func set_sky(sky_name: String):
environment.sky.sky_material = load("res://map/environment/presets/%s_sky.tres" % sky_name)
func _ready():
- Settings.hook_changed_init("graphics.ssao", "main", func (x): environment.ssao_enabled = x)
- Settings.hook_changed_init("graphics.gi", "main", func (x): environment.sdfgi_enabled = x == "sdfgi" and allow_sdfgi)
- Settings.hook_changed_init("graphics.glow", "main", func (x): environment.glow_enabled = x)
+ Settings.hook_changed_init("graphics.ssao", self, func (x): environment.ssao_enabled = x)
+ Settings.hook_changed_init("graphics.gi", self, func (x): environment.sdfgi_enabled = x == "sdfgi" and allow_sdfgi)
+ Settings.hook_changed_init("graphics.glow", self, func (x): environment.glow_enabled = x)
if !Global.on_vulkan():
environment.environment.tonemap_exposure = 0.5
diff --git a/client/map/auto_setup/light_setup.gd b/client/map/auto_setup/light_setup.gd
index 0d71f54b..e63a6ab9 100644
--- a/client/map/auto_setup/light_setup.gd
+++ b/client/map/auto_setup/light_setup.gd
@@ -20,7 +20,7 @@ class_name LightSetup
var shadows_enabled: bool
func _ready():
- Settings.hook_changed_init("graphics.shadows", "main", apply_settings)
+ Settings.hook_changed_init("graphics.shadows", self, apply_settings)
func set_visible_(val: bool):
if completely_disable_light_if_shadows_disabled and not shadows_enabled:
diff --git a/client/map/map.gd b/client/map/map.gd
index f6cb2f82..150520d7 100644
--- a/client/map/map.gd
+++ b/client/map/map.gd
@@ -62,7 +62,7 @@ func clear_tile(pos: Vector2i):
@onready var voxelgi: VoxelGI = $VoxelGI
func _ready():
- Settings.hook_changed("graphics.gi", "main", apply_gi_setting)
+ Settings.hook_changed("graphics.gi", self, apply_gi_setting)
floor_node.material_override = preload("res://map/tiles/floor_material.tres")
for fm in tile_factory.floor_meshers.values():
add_child(fm.mesh_instance)