Merge pull request 'Refactor settings system and localization' (#123) from new-settings into master

Reviewed-on: https://codeberg.org/hurrycurry/hurrycurry/pulls/123

1 files changed, 8 insertions, 17 deletions

diff --git a/client/menu/settings/dropdown_setting.gd b/client/menu/settings/dropdown_setting.gd
index e57fc40f..3d6b7c80 100644
--- a/client/menu/settings/dropdown_setting.gd
+++ b/client/menu/settings/dropdown_setting.gd
@@ -18,23 +18,14 @@ extends GameSetting
 
 var options: Array
 
-func _init(new_description: String, new_preset: int, new_options: Array):
-	assert(new_preset < new_options.size())
-	super(new_description, new_preset)
+func _init(new_id: String, new_default, new_options: Array):
+	super(new_id, new_default)
 	options = new_options
 
-func _update_row():
-	super()
+func create_row():
+	var row = super()
 	row.value_node = OptionButton.new()
-	for i in options:
-		row.value_node.add_item(i)
-	row.value_node.select(_value)
-
-func fetch_setting():
-	if row != null:
-		_value = row.value_node.selected
-
-func set_value(v):
-	super(v)
-	if row != null:
-		row.value_node.selected = _value
+	for i in options: row.value_node.add_item(tr(nskey + "." + i))
+	Settings.hook_changed_init(key, true, func (value): row.value_node.select(options.find(value)))
+	row.value_node.item_selected.connect(func(item): Global.set_setting(key, options[item]))
+	return row