Improve server logging and use central player id counter (close #450)

1 files changed, 5 insertions, 5 deletions

diff --git a/server/src/entity/bot.rs b/server/src/entity/bot.rs
index 26ae77a6..78b300b6 100644
--- a/server/src/entity/bot.rs
+++ b/server/src/entity/bot.rs
@@ -19,8 +19,8 @@ use super::{Entity, EntityContext};
 use anyhow::Result;
 use hurrycurry_bot::{BotAlgo, DynBotAlgo};
 use hurrycurry_protocol::{Character, Hand, PacketS, PlayerClass, PlayerID};
-use log::info;
-use std::{any::Any, random::random};
+use log::debug;
+use std::any::Any;
 
 pub type DynBotDriver = BotDriver<DynBotAlgo>;
 
@@ -49,8 +49,8 @@ impl<T: BotAlgo + Any> Entity for BotDriver<T> {
     }
     fn tick(&mut self, c: EntityContext<'_>) -> Result<()> {
         if let Some((name, character, class)) = self.join_data.take() {
-            self.id = PlayerID(random(..)); // TODO bad code, can collide
-            info!("spawn {:?} ({name:?})", self.id);
+            self.id = c.game.get_unused_player_id(); // TODO clashes when multiple bots join in the same tick
+            debug!("join {}", self.id);
             c.packet_in.push_back(PacketS::Join {
                 name,
                 character,
@@ -62,7 +62,7 @@ impl<T: BotAlgo + Any> Entity for BotDriver<T> {
 
         let input = self.algo.tick(self.id, c.game, c.dt);
         if input.leave {
-            info!("leave {:?}", self.id);
+            debug!("leave {}", self.id);
             c.packet_in.push_back(PacketS::Leave { player: self.id });
             self.left = true;
             return Ok(());